Update New Ticket button styling - #1354
Open
jmartinez-tacc wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 64.20% 64.20%
=======================================
Files 464 464
Lines 13866 13866
Branches 2771 2771
=======================================
Hits 8903 8903
Misses 4609 4609
Partials 354 354
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
fnets
approved these changes
Sep 2, 2026
fnets
left a comment
fnets
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Good use of the CSS variables
rstijerina
reviewed
Sep 2, 2026
| <Link | ||
| to={`${ROUTES.WORKBENCH}${ROUTES.DASHBOARD}${ROUTES.TICKETS}/create`} | ||
| className="btn btn-secondary btn-sm" | ||
| className={styles['btn-new-ticket']} |
Member
There was a problem hiding this comment.
Would the existing class names for c-button work here? Like
Suggested change
| className={styles['btn-new-ticket']} | |
| className="c-button c-button--secondary c-button--sm" |
Contributor
Author
There was a problem hiding this comment.
I tried that, it didn't work.
c-button classes are for <Button> some of the styling are not applied to this <Link> tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update New Ticket button styling to be consistent with the other buttons style
Related
Changes
Testing
UI
Notes